feat: implement support for array values in from property. Closes #631#645
Closed
orangy wants to merge 1 commit intowebpack:masterfrom
Closed
feat: implement support for array values in from property. Closes #631#645orangy wants to merge 1 commit intowebpack:masterfrom
from property. Closes #631#645orangy wants to merge 1 commit intowebpack:masterfrom
Conversation
| `Invalid "pattern.from": ${item.from}, every element should be a string"` | ||
| ) | ||
| ); | ||
| } |
Member
There was a problem hiding this comment.
Avoid it, you validate it in schema already
| ) | ||
| ) | ||
| )) | ||
| ); |
Member
There was a problem hiding this comment.
Why not pass array to globby? They support it https://github.com/sindresorhus/globby#usage
| }, | ||
| "to": { | ||
| "anyOf": [ | ||
| "oneOf": [ |
|
Hi, I need this feature too, I notice this PR is stopped for a year, what can I do or contribute to make it go? |
Member
|
Yes, feel free to send a new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains an implementation for processing arrays in
fromproperty, and is:Motivation / Use-Case
In my project I'm missing
transformAllon a bunch of files, so I've found a recent issue #631 and decided to implement it.Breaking Changes
There shouldn't be any breaking changes since it doesn't disable or break any scenario that was possible before, and only creates new (wonderful!) possibility to make copy scripts shorter and more powerful.
Additional Info